Trackpanel accessibility: incorrect focus can be read
Problem: If the initial focus is a control in a toolbar, then after applying an effect such as amplify, then the focus is read as being a track, not the control in the toolbar....
View ArticleGrid accessibility: incorrect focus can be read
Problem: this affects NVDA and Narrator, but not Jaws. If a user moves to the Delete button and presses it to delete a label, a label is incorrectly read as the new focus - the focus remains on the...
View ArticleSome naming consistency...
Prefer "MissingAliasFiles" not other permutations of the words
View ArticleMissing alias file tracking out of AudacityApp, into new files...
... which reduces the need for including AudacityApp.h
View ArticleDon't call QuitAudacity directly from src/menus...
... This cuts link dependency on AudacityApp.cpp, and allows the function to be private to that file
View ArticleScriptCommandRelay.cpp is not link dependent on AudacityApp.cpp ...
... Let it send an event to the application instead of calling the handler directly.
View ArticleMove ProjectFSCK out of DirManager...
... which makes DirManager.cpp not depend on MissingAliasFileDialog.cpp
View ArticleMove ShuttleGetDefinition to its own files...
... so Shuttle need not include CommandTargets.h
View ArticleGlobal keyboard capture handling into new files, better comments...
... and break its compile dependency on CommandManager.h by letting it install callbacks. This also removes Objective-C mixed code from CommmandManager. This also eliminates four inclusions of...
View ArticleInternat.cpp has fewer dependencies...
... after we move a function to FileNames.cpp. This frees ten files from cyclic dependencies
View ArticlePrefs.cpp has fewer dependencies...
... when special initial population of preferences is lifted into AudacityApp.cpp. This takes four files out of the big strongly connected component of the graph into low levels, but three of them...
View ArticleShuttleGui.cpp and ShuttlePrefs.cpp have fewer dependencies...
... Freeing 13 files from cyclic dependencies
View ArticleHelpText.cpp has fewer dependencies...
... freeing it to a low level and AboutDialog.cpp to a high level, by moving functions from the latter into the former
View ArticleHelpSystem.cpp has fewer dependencies...
... There was no reason to store the help location preferences as per-project state. Also move the dialog for quick fixes near its only use in HelpMenus.cpp. This takes 22 files out of the big...
View ArticleDither.cpp and SampleFormat.cpp have fewer dependencies...
... Notably they longer depend indirectly on AudioIO.cpp (via QualityPrefs) This frees nine files from dependency cycles
View ArticleTheme.cpp has fewer dependencies...
It remains in a cycle with ImageManipulation, but the two are free from other cycles
View ArticleRecordingPrefs.cpp does not depend on AudioIO.cpp...
... freeing it from dependency cycles, but no others
View ArticleThemePrefs.cpp has fewer dependencies...
... Send an event via the app that projects listen to for theme update; don't push it to projects directly. This frees three files from dependency cycles.
View ArticleXMLTagHandler.cpp has fewer dependencies...
... freeing three files from dependency cycles
View ArticleMove class ODTaskThread out of ODTaskThread.* (!) ...
... freeing three files from dependency cycles. The class is only constructed by ODManager so move its definition there. Meanwhile, the (now misnamed) ODTaskThread.cpp implements some thread...
View ArticleScreenshotCommand uses hooks in AudacityCommand and Effect dialogs...
... so that they don't have a static linkage dependency on it, and that frees it from dependency cycles, to a high level
View ArticleCommandTargets.cpp has fewer dependencies...
... freeing two files from dependency cycles
View Article